Re: [Qemu-devel] [RFC PATCH 17/21] hmp: expose status of plugins to the monitor

[Markus Armbruster]

"Dr. David Alan Gilbert" <address@hidden> writes:

> * Alex Bennée (address@hidden) wrote:
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>>  hmp-commands-info.hx   | 17 +++++++++++++++++
>>  include/qemu/plugins.h |  1 +
>>  monitor.c              | 14 ++++++++++++++
>>  trace/plugins.c        | 15 +++++++++++++++
>>  4 files changed, 47 insertions(+)
>
> I'm OK with this; although it's worth thinking about whether this should
> be available via qmp, but it is just for debug/tracing.

Standard operating procedure for adding HMP commands without a QMP
equivalent: have the commit message explain why the QMP equivalent isn't
useful.

> Reviewed-by: Dr. David Alan Gilbert <address@hidden>