[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 37/56] mips: convert to cpu_interrupt_request
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC v3 37/56] mips: convert to cpu_interrupt_request |
Date: |
Sun, 21 Oct 2018 14:30:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/19/18 2:06 AM, Emilio G. Cota wrote:
> @@ -60,7 +60,7 @@ static bool mips_cpu_has_work(CPUState *cs)
> /* Prior to MIPS Release 6 it is implementation dependent if non-enabled
> interrupts wake-up the CPU, however most of the implementations only
> check for interrupts that can be taken. */
> - if ((cs->interrupt_request & CPU_INTERRUPT_HARD) &&
> + if ((cpu_interrupt_request(cs) & CPU_INTERRUPT_HARD) &&
> cpu_mips_hw_interrupts_pending(env)) {
> if (cpu_mips_hw_interrupts_enabled(env) ||
> (env->insn_flags & ISA_MIPS32R6)) {
> @@ -72,7 +72,7 @@ static bool mips_cpu_has_work(CPUState *cs)
> if (env->CP0_Config3 & (1 << CP0C3_MT)) {
> /* The QEMU model will issue an _WAKE request whenever the CPUs
> should be woken up. */
> - if (cs->interrupt_request & CPU_INTERRUPT_WAKE) {
> + if (cpu_interrupt_request(cs) & CPU_INTERRUPT_WAKE) {
> has_work = true;
> }
>
> @@ -82,7 +82,7 @@ static bool mips_cpu_has_work(CPUState *cs)
> }
> /* MIPS Release 6 has the ability to halt the CPU. */
> if (env->CP0_Config5 & (1 << CP0C5_VP)) {
> - if (cs->interrupt_request & CPU_INTERRUPT_WAKE) {
> + if (cpu_interrupt_request(cs) & CPU_INTERRUPT_WAKE) {
> has_work = true;
> }
> if (!mips_vp_active(env)) {
Multiple calls.
r~
- [Qemu-devel] [RFC v3 44/56] unicore32: convert to cpu_interrupt_request, (continued)
- [Qemu-devel] [RFC v3 44/56] unicore32: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 17/56] s390x: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 35/56] lm32: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 47/56] cpu: call .cpu_has_work with the CPU lock held, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 43/56] openrisc: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 37/56] mips: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- Re: [Qemu-devel] [RFC v3 37/56] mips: convert to cpu_interrupt_request,
Richard Henderson <=
- [Qemu-devel] [RFC v3 42/56] sparc: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 30/56] i386: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 49/56] mips: acquire the BQL in cpu_has_work, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 51/56] riscv: acquire the BQL in cpu_has_work, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 52/56] sparc: acquire the BQL in cpu_has_work, Emilio G. Cota, 2018/10/18