Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

[Michael S. Tsirkin]

On Mon, Oct 22, 2018 at 08:36:30PM +0200, Samuel Ortiz wrote:
> This patch set implements support for the ACPI hardware-reduced
> specification.
> 
> The changes are coming from the NEMU [1] project where we're defining
> a new x86 machine type: i386/virt. This is an EFI only, ACPI
> hardware-reduced platform and as such we had to implement support
> for the latter.
> 
> As a preliminary for adding hardware-reduced support to QEMU, we did
> some ACPI code reorganization with the following goals:
> 
> * Share as much as possible of the current ACPI build APIs between
>   legacy and hardware-reduced ACPI.
> * Share the ACPI build code across machine types and architectures and
>   remove the typical PC machine type dependency.
>   Eventually we hope to see arm/virt also re-use much of that code.
> 
> The rest of the patchset adds the hardware-reduced support on top of
> this code reorganization. Here again, the implementation is machine
> type, platform and architecture independent.
> 
> [1] https://github.com/intel/nemu


Thanks for the patch!
I'm traveling so won't be able to review until next week.

I wonder whether the code can be refactored slightly differently:
instead of common code calling out to platform specific one,
have platform code call out to generic one.
That would avoid indicectiin but I'm not sure at what cost
in complexity.

Still that's a generic question as I have not looked at the
patches in depth.

Hope this helps,
MST

> 
> The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8:
> 
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
> staging (2018-10-19 19:01:07 +0100)
> 
> are available in the Git repository at:
> 
>   address@hidden:intel/nemu topic/upstream/acpi
> 
> for you to fetch changes up to 4133ebe0d638d0a3d583bd89aa2360ef35ba746b:
> 
>   hw: acpi: reduced: Add PCI hotplug support (2018-10-22 20:32:23 +0200)
> 
> ----------------------------------------------------------------
> Jing Liu (2):
>       hw: acpi: reduced: Add shutdown support
>       hw: acpi: reduced: Add reboot support
> 
> Samuel Ortiz (10):
>       hw: i386: Decouple the ACPI build from the PC machine type
>       hw: acpi: Export ACPI build alignment API
>       hw: acpi: Export the RSDP build API
>       hw: arm: Switch to the AML build RSDP building routine
>       hw: acpi: Do not create hotplug method when handler is not defined
>       hw: i386: Make the hotpluggable memory size property more generic
>       hw: fw-build: Add firmware build methods and state
>       hw: i386: Convert PC machine type to firmware build methods
>       hw: acpi: Initial hardware-reduced support
>       hw: acpi: reduced: Generic Event Device support
> 
> Sebastien Boeuf (4):
>       hw: acpi: Export the PCI hotplug API
>       hw: acpi: Retrieve the PCI bus from AcpiPciHpState
>       hw: acpi: reduced: Add NFIT support
>       hw: acpi: reduced: Add PCI hotplug support
> 
> Yang Zhong (10):
>       hw: acpi: Generalize AML build routines
>       hw: acpi: Factorize _OSC AML across architectures
>       hw: i386: Refactor PCI host getter
>       hw: acpi: Export and generalize the PCI host AML API
>       hw: acpi: Export the MCFG getter
>       hw: acpi: Export the SRAT AML build API
>       hw: acpi: Fix memory hotplug AML generation error
>       hw: acpi: reduced: Add MCFG support
>       hw: acpi: reduced: Add memory hotplug support
>       hw: acpi: reduced: Add SRAT table
> 
>  default-configs/i386-softmmu.mak |    1 +
>  hw/acpi/Makefile.objs            |    1 +
>  hw/acpi/aml-build.c              | 1139 +++++++++++++++++++++++++++++++++++-
>  hw/acpi/cpu.c                    |    8 +-
>  hw/acpi/cpu_hotplug.c            |    9 +-
>  hw/acpi/memory_hotplug.c         |   21 +-
>  hw/acpi/pcihp.c                  |   10 +-
>  hw/acpi/reduced.c                |  472 +++++++++++++++
>  hw/arm/virt-acpi-build.c         |   86 +--
>  hw/i386/acpi-build.c             | 1172 
> +++-----------------------------------
>  hw/i386/acpi-build.h             |    4 +-
>  hw/i386/pc.c                     |  188 +++---
>  hw/i386/pc_piix.c                |   21 +-
>  hw/i386/pc_q35.c                 |   21 +-
>  hw/pci-host/piix.c               |    8 -
>  include/hw/acpi/acpi-defs.h      |   15 +
>  include/hw/acpi/acpi.h           |   47 ++
>  include/hw/acpi/aml-build.h      |   48 ++
>  include/hw/acpi/reduced.h        |   46 ++
>  include/hw/boards.h              |    5 +
>  include/hw/fw-build.h            |   57 ++
>  include/hw/i386/acpi.h           |   27 +
>  include/hw/i386/pc.h             |   21 +-
>  include/hw/mem/memory-device.h   |    2 +
>  stubs/Makefile.objs              |    1 -
>  stubs/pci-host-piix.c            |    6 -
>  26 files changed, 2107 insertions(+), 1329 deletions(-)
>  create mode 100644 hw/acpi/reduced.c
>  create mode 100644 include/hw/acpi/reduced.h
>  create mode 100644 include/hw/fw-build.h
>  create mode 100644 include/hw/i386/acpi.h
>  delete mode 100644 stubs/pci-host-piix.c
> 
> -- 
> 2.17.2
>