[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt |
Date: |
Mon, 22 Oct 2018 19:28:55 -0400 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Sun, Oct 21, 2018 at 14:17:01 +0100, Richard Henderson wrote:
> On 10/19/18 2:05 AM, Emilio G. Cota wrote:
> > - cpu->interrupt_request &= ~0x01;
> > + cpu_reset_interrupt(cpu, ~0x01);
>
> cpu_reset_interrupt(cpu, 1);
Ouch. Fixed.
> Although this is during vmload, and I'm not sure what locks you really want to
> play with here. Perhaps it's ok...
I checked with check-qtest that it's OK -- note that the lock
is initialized right after the CPU thread is created.
I'd like to keep the locked version, so that race checkers don't
get confused.
Thanks,
Emilio
- Re: [Qemu-devel] [RFC v3 26/56] i386: use cpu_reset_interrupt, (continued)
- [Qemu-devel] [RFC v3 22/56] cpu-exec: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 15/56] mips: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 21/56] openrisc: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 14/56] m68k: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 25/56] exec: use cpu_reset_interrupt, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 18/56] sparc: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 12/56] i386: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 28/56] openrisc: use cpu_reset_interrupt, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 32/56] sh4: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 24/56] ppc: use cpu_reset_interrupt, Emilio G. Cota, 2018/10/18