qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from tra


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders
Date: Tue, 23 Oct 2018 14:08:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 10/23/18 2:04 PM, Bastian Koppelmann wrote:
> On 10/23/18 2:04 PM, Richard Henderson wrote:
>> ??? Needs simultaneous corresponding changes to all
>> translators using decodetree.
>> ---
>>   scripts/decodetree.py | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
> 
> Was the only intend of the insn argument to be used for manual decoding in a
> trans_ function?

I didn't quite know what it might be used for, and thought I was planning
ahead.  Now I see that it's probably counter-productive.

In particular, think of how you were calling the trans_foo functions yourself,
passing along the uint16_t input to the uint32_t output.  Which would have
worked not at all had you actually been using it for decode within the insn32
code base.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]