|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 01/26] hw: i386: Decouple the ACPI build from the PC machine type |
Date: | Wed, 24 Oct 2018 00:24:53 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 22/10/2018 20:36, Samuel Ortiz wrote: > +static void acpi_conf_pc_init(MachineState *machine) This should take a PCMachineState*, since you never use "machine" except for downcasting. Paolo > +{ > + PCMachineState *pcms = PC_MACHINE(machine); > + PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(machine); > + AcpiConfiguration *conf = &pcms->acpi_configuration; > + > + /* Machine class settings */ > + conf->legacy_acpi_table_size = pcmc->legacy_acpi_table_size; > + conf->legacy_cpu_hotplug = pcmc->legacy_cpu_hotplug; > + conf->rsdp_in_ram = pcmc->rsdp_in_ram; > + > + /* ACPI build state */ > + conf->build_state = NULL; > +} > +
[Prev in Thread] | Current Thread | [Next in Thread] |