[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] target/arm: Introduce read_sys_reg32 for kv
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] target/arm: Introduce read_sys_reg32 for kvm32 |
Date: |
Wed, 24 Oct 2018 13:49:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/24/18 12:37 PM, Richard Henderson wrote:
> - int i, ret, fdarray[3];
> + int i, err = 0, fdarray[3];
Bah. The bit about having compile-tested for arm32 was fake news -- "i" is now
unused. Ho hum.
> @@ -77,16 +69,15 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures
> *ahcf)
> */
> ahcf->dtb_compatible = "arm,arm-v7";
>
> - for (i = 0; i < ARRAY_SIZE(idregs); i++) {
> - ret = ioctl(fdarray[2], KVM_GET_ONE_REG, &idregs[i]);
> - if (ret) {
> - break;
> - }
> - }
> + err |= read_sys_reg32(fdarray[2], &midr, ARM_CP15_REG32(0, 0, 0, 0));
> + err |= read_sys_reg32(fdarray[2], &id_pfr0, ARM_CP15_REG32(0, 0, 1, 0));
> + err |= read_sys_reg32(fdarray[2], &mvfr1,
> + KVM_REG_ARM | KVM_REG_SIZE_U32 |
> + KVM_REG_ARM_VFP | KVM_REG_ARM_VFP_MVFR1);
r~
- [Qemu-devel] [PATCH 0/5] target/arm: KVM vs ARMISARegisters, Richard Henderson, 2018/10/24
- [Qemu-devel] [PATCH 4/5] target/arm: Fill in ARMISARegisters for kvm32, Richard Henderson, 2018/10/24
- [Qemu-devel] [PATCH 2/5] target/arm: Fill in ARMISARegisters for kvm64, Richard Henderson, 2018/10/24
- [Qemu-devel] [PATCH 3/5] target/arm: Introduce read_sys_reg32 for kvm32, Richard Henderson, 2018/10/24
- Re: [Qemu-devel] [PATCH 3/5] target/arm: Introduce read_sys_reg32 for kvm32,
Richard Henderson <=
- [Qemu-devel] [PATCH 5/5] target/arm: Convert t32ee from feature bit to isar3 test, Richard Henderson, 2018/10/24
- [Qemu-devel] [PATCH 1/5] target/arm: Install ARMISARegisters from kvm host, Richard Henderson, 2018/10/24