|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated |
Date: | Thu, 25 Oct 2018 13:17:27 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 25/10/18 10:52, Gerd Hoffmann wrote:
While being at it deprecate cirrus too. Reason (short version): use stdvga instead. Verbose version: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful Signed-off-by: Gerd Hoffmann <address@hidden> --- hw/display/cirrus_vga.c | 2 ++ hw/display/cirrus_vga_isa.c | 2 ++ qemu-deprecated.texi | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index d9b854d..2f16ba9 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -3024,6 +3024,8 @@ static void cirrus_vga_class_init(ObjectClass *klass, void *data) dc->vmsd = &vmstate_pci_cirrus_vga; dc->props = pci_vga_cirrus_properties; dc->hotpluggable = false; + dc->deprecation_reason = + "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful";
We should propably add an archived copy of this post to www.qemu.org. Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
}static const TypeInfo cirrus_vga_info = {diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c index fa10b74..c2d853c 100644 --- a/hw/display/cirrus_vga_isa.c +++ b/hw/display/cirrus_vga_isa.c @@ -81,6 +81,8 @@ static void isa_cirrus_vga_class_init(ObjectClass *klass, void *data) dc->realize = isa_cirrus_vga_realizefn; dc->props = isa_cirrus_vga_properties; set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); + dc->deprecation_reason = + "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful"; }static const TypeInfo isa_cirrus_vga_info = {diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 7951a4f..1b1d434 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -120,6 +120,10 @@ or ``ivshmem-doorbell`` device types.Has known buffer overflow. address@hidden cirrus (since 3.1)+ +Use stdvga instead (-vga std or -device VGA). + @section System emulator machines@subsection pc-0.10 and pc-0.11 (since 3.0)
[Prev in Thread] | Current Thread | [Next in Thread] |