[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] range: pass const pointer where possible
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] range: pass const pointer where possible |
Date: |
Thu, 25 Oct 2018 15:41:58 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Oct 23, 2018 at 05:23:02PM +0200, David Hildenbrand wrote:
> If there are no changes, let's use a const pointer.
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> include/qemu/range.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/range.h b/include/qemu/range.h
> index f28f0c1825..7e75f4e655 100644
> --- a/include/qemu/range.h
> +++ b/include/qemu/range.h
> @@ -39,7 +39,7 @@ struct Range {
> uint64_t upb; /* inclusive upper bound */
> };
>
> -static inline void range_invariant(Range *range)
> +static inline void range_invariant(const Range *range)
> {
> assert(range->lob <= range->upb || range->lob == range->upb + 1);
> }
> @@ -48,14 +48,14 @@ static inline void range_invariant(Range *range)
> #define range_empty ((Range){ .lob = 1, .upb = 0 })
>
> /* Is @range empty? */
> -static inline bool range_is_empty(Range *range)
> +static inline bool range_is_empty(const Range *range)
> {
> range_invariant(range);
> return range->lob > range->upb;
> }
>
> /* Does @range contain @val? */
> -static inline bool range_contains(Range *range, uint64_t val)
> +static inline bool range_contains(const Range *range, uint64_t val)
> {
> return val >= range->lob && val <= range->upb;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature