Re: [Qemu-devel] [PATCH v7 12/20] target/mips: Add emulation of MXU instructions S32I2M and S32M2I

[Aleksandar Markovic]

> Subject: [PATCH v7 12/20] target/mips: Add emulation of MXU instructions 
> S32I2M and S32M2I
> 
> From: Craig Janeczek <address@hidden>
> 
> Add support for emulating the S32I2M and S32M2I MXU instructions.
> This commit also contains utility functions for reading/writing
> to MXU registers. This is required for overall MXU instruction
> support.
> 
> Signed-off-by: Craig Janeczek <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---

Not all bits of MXU_CR are RW. RW-rules should be included in this patch. Or, 
at minimum, a "TODO" note should be inserted in the appropiriate handler.

Other than this:

Reviewed-by: Aleksandar Markovic <address@hidden>

Thanks,
Aleksandar