Re: [Qemu-devel] [PATCH 1/1] i386: Add PKU/OSPKE on Skylake-Server CPU model

[Tao Xu]

On 10/26/18 4:22 PM, Eduardo Habkost wrote:
> On Fri, Oct 26, 2018 at 01:53:10PM +0800, Tao Xu wrote:
> > On 10/25/18 9:28 PM, Eduardo Habkost wrote:
> >
> > > Sorry for taking so long to reply.  This can be safely done only
> > > if every host that is able to run Skylake-Server today is
> > > guaranteed to support PKU.  Is that the case?

Yes, as the release document ref below link (page 13):
https://software.intel.com/sites/default/files/managed/c5/15/\
architecture-instruction-set-extensions-programming-reference.pdf

PKU is supported in Skylake Server (Only Server) and later.
So, every host that is able to run Skylake-Server today is to
to support PKU.

> > > You'll also need Skylake-Server-*-cpu.pku=off entries on
> > > PC_COMPAT_3_0 to keep PKU disabled on pc-*-3.0 and older.
> > Thank you Eduardo,
> >
> >
> > But I can't find PC_COMPAT_3_0 in  include/hw/i386/pc.h. Will it exist on
> >
> > QEMU 3.1 and will I add "pku=off" after QEMU 3.1  release?
> PC_COMPAT_3_0 was added to qemu.git master a few weeks ago, by
> commit 9b4cf107b09d18ac30f46fd1c4de8585ccba030c.
Thank you. I'll add this on the next version of this patch.