Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Tue, Oct 9, 2018 at 8:41 PM Markus Armbruster <address@hidden> wrote:
>>
>> Markus Armbruster <address@hidden> writes:
>>
>> > Thomas Huth <address@hidden> writes:
>> >
>> >> On 2018-08-31 15:24, Marc-André Lureau wrote:
[...]
>> >>> Tbh, I don't care so much about the naming of the test, but (for once)
>> >>> I respectfully don't think Markus suggestion is better.
>> >>>
>> >>> The function checks "qom-set" without 'value' argument:
>> >>> "qom-set-without-value", no brainer..
>> >
>> > Nope, that's not what it tests.  It tests the visitor, the marshalling
>> > code generator, and the QMP core handle a certain kind of invalid
>> > arguments correctly.  It does not test qom-set.  I explained all that
>> > already.
>> >
>> >>> Naming it "invalid-arg" is so generic that I wouldn't be able what it 
>> >>> does.
>> >
>> > I can accept "missing-any" or "missing-any-arg".  I object to any name
>> > involving qom-set, because the test is not about qom-set at all.
>> >
>> > If it was, then putting it in qmp-test.c would be wrong.
>> >
>> >> Ok, then let's keep it this way. As I said, IMHO the current naming is
>> >> not really bad, and I also don't have any suggestions for a perfect name
>> >> right now.
>> >
>> > We don't need a perfect name.  We need one that's not actively
>> > misleading.
>>
>> Marc-André, would "qmp/missing-any-arg" and test_missing_any_arg() work
>> for you?
>
> Yes, do you want me to update the patch?

Yes, please.