Re: [Qemu-devel] [PATCH RFC 4/4] net/slirp: add ipv6-hostfwd option for user netdev type

[Maxim Samoylov]

On 26.10.2018 09:14, Thomas Huth wrote:
> On 2018-10-26 01:03, Maxim Samoylov wrote:
> > This allows forwarding TCP6 and UDP6 connections down to
> > netdev=user connected guests.
> >
> > Signed-off-by: Maxim Samoylov <address@hidden>
> > ---
> >   hmp-commands.hx     |  31 ++++++++
> >   include/net/slirp.h |   2 +
> >   net/slirp.c         | 214 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   qapi/net.json       |   3 +-
> >   4 files changed, 249 insertions(+), 1 deletion(-)
> >
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index db0c681..b0e1a08 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1448,6 +1448,37 @@ STEXI
> >   Remove host-to-guest TCP or UDP redirection.
> >   ETEXI
> >   
> > +#ifdef CONFIG_SLIRP
> > +    {
> > +        .name       = "ipv6_hostfwd_add",
> > +        .args_type  = "arg1:s,arg2:s?,arg3:s?",
> > +        .params     = "[hub_id name]|[netdev_id] 
> > [tcp|udp]:[hostaddr6]:hostport-guestaddr6:guestport",
> > +        .help       = "redirect TCP6 or UDP6 connections from host to guest 
> > (requires -net user)",
> > +        .cmd        = hmp_ipv6_hostfwd_add,
> > +    },
> > +#endif
> > +STEXI
> > address@hidden hostfwd_add
> > address@hidden hostfwd_add
> > +Redirect TCP6 or UDP6 connections from host to guest (requires -net user).
> > +ETEXI
> > +
> > +#ifdef CONFIG_SLIRP
> > +    {
> > +        .name       = "ipv6_hostfwd_remove",
> > +        .args_type  = "arg1:s,arg2:s?,arg3:s?",
> > +        .params     = "[hub_id name]|[netdev_id] 
> > [tcp|udp]:[hostaddr6]:hostport",
> > +        .help       = "remove host-to-guest TCP6 or UDP6 redirection",
> > +        .cmd        = hmp_ipv6_hostfwd_remove,
> > +    },
>
>   Hi,
>
> could you please remove the "[hub_id name]" touple here? I recently sent
> a patch to deprecate it for the IPv4 version, too:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03198.html

Ok

> Also I think it would make sense if you mention in the help text that
> IPv6 addresses have to be given with square brackets?
>
>   Thanks,
>    Thomas

Sure, missed that thing.

---
Maxim Samoylov, address@hidden