|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files |
Date: | Tue, 30 Oct 2018 16:02:59 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 30/10/18 14:08, Peter Maydell wrote:
On 30 October 2018 at 13:01, Peter Maydell <address@hidden> wrote:...having sent this out and moved on to something else, I have discovered a problem with it. If you configure a build tree using this, and then switch back to a git branch which has the older configure, then that configure will end up trashing all the tests/acpi-test-data and tests/hex-loader-check-data files in the source tree by replacing them with symlinks to themselves... This is fixable by doing "git checkout tests" but it's a bit of a landmine for bisection :-(
Got there now switching to another series after testing yours ;)
Maybe we should standardize on having all data files for tests be in tests/data, which is and has always been a symlink to a directory. That would avoid this problem with old versions of configure mangling the source directory by accident.
This seems the clever move.
thanks -- PMM
[Prev in Thread] | Current Thread | [Next in Thread] |