Re: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8f42ee8aa7 qga-win: changing --retry-path option behavior
9abf73aeb7 qga-win: report specific error when failing to open channel
c05c7e4b5e qga-win: install service with --retry-path set by default
06dbce634a qga: add --retry-path option for re-initializing channel on failure
55aeec1626 qga: move w32 service handling out of run_agent()
423fc8d618 qga: hang GAConfig/socket_activation off of GAState global
b5ec835db3 qga: group agent init/cleanup init separate routines
830dbe1974 qga: fix an off-by-one issue
83412291a9 qga-win: demystify namespace stripping
429d56cb25 qga-win: return disk device in guest-get-fsinfo
fe3c8c5215 qga-win: handle multi-disk volumes
30caf40e15 qga-win: refactor disk info
171348f603 qga-win: report disk serial number
f3ae9514ec qga-win: refactor disk properties (bus)
90c4266768 qga-win: add debugging information
bd20b26d23 build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI
be323b6d8b qga-win: fsinfo: pci-info: allow partial info
f6fc8e99e0 qga-win: prevent crash when executing fsinfo command
7ed266cc7b qga: linux: return disk device in guest-get-fsinfo
b215b4cc87 qga: linux: report disk serial number
2022b5f4ca configure: add test for libudev
9769d6747f qga: ignore non present cpus when handling qmp_guest_get_vcpus()
154d62ea2b qga-win: add support for qmp_guest_fsfreeze_freeze_list
9f778d9064 qga: Support Unicode paths in guest-file-open on win32

=== OUTPUT BEGIN ===
Checking PATCH 1/24: qga: Support Unicode paths in guest-file-open on win32...
Checking PATCH 2/24: qga-win: add support for qmp_guest_fsfreeze_freeze_list...
Checking PATCH 3/24: qga: ignore non present cpus when handling 
qmp_guest_get_vcpus()...
Checking PATCH 4/24: configure: add test for libudev...
Checking PATCH 5/24: qga: linux: report disk serial number...
Checking PATCH 6/24: qga: linux: return disk device in guest-get-fsinfo...
Checking PATCH 7/24: qga-win: prevent crash when executing fsinfo command...
Checking PATCH 8/24: qga-win: fsinfo: pci-info: allow partial info...
Checking PATCH 9/24: build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI...
Checking PATCH 10/24: qga-win: add debugging information...
Checking PATCH 11/24: qga-win: refactor disk properties (bus)...
Checking PATCH 12/24: qga-win: report disk serial number...
WARNING: line over 80 characters
#39: FILE: qga/commands-win32.c:652:
+            error_setg(errp, "failed to get serial number: offset outside the 
buffer");

total: 0 errors, 1 warnings, 36 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/24: qga-win: refactor disk info...
Checking PATCH 14/24: qga-win: handle multi-disk volumes...
ERROR: "foo*bar" should be "foo *bar"
#148: FILE: qga/commands-win32.c:786:
+                + extents->NumberOfDiskExtents*sizeof(DISK_EXTENT);

total: 1 errors, 0 warnings, 185 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/24: qga-win: return disk device in guest-get-fsinfo...
Checking PATCH 16/24: qga-win: demystify namespace stripping...
Checking PATCH 17/24: qga: fix an off-by-one issue...
Checking PATCH 18/24: qga: group agent init/cleanup init separate routines...
Checking PATCH 19/24: qga: hang GAConfig/socket_activation off of GAState 
global...
Checking PATCH 20/24: qga: move w32 service handling out of run_agent()...
Checking PATCH 21/24: qga: add --retry-path option for re-initializing channel 
on failure...
Checking PATCH 22/24: qga-win: install service with --retry-path set by 
default...
Checking PATCH 23/24: qga-win: report specific error when failing to open 
channel...
Checking PATCH 24/24: qga-win: changing --retry-path option behavior...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden