[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: add qmp/missing-any-arg test
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests: add qmp/missing-any-arg test |
|
Date: |
Wed, 31 Oct 2018 17:43:13 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
> On Wed, Oct 31, 2018 at 7:22 PM Markus Armbruster <address@hidden> wrote:
>>
>> Marc-André Lureau <address@hidden> writes:
>>
>> > test_qmp_missing_any_arg() is about a bug in infrastructure used by
>> > the QMP core, fixed in commit c489780203. We covered the bug in
>> > infrastructure unit tests (commit bce3035a44). I wrote that test
>> > earlier, to cover QMP level as well, the test could go into qmp-test.
>>
>> The last sentence is confusing. What about replacing it by "Let's test
>> it at the QMP level as well"?
>
> sure, I assume you do that on commit thanks
Can do.
Meanwhile,
Reviewed-by: Markus Armbruster <address@hidden>