qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 22/35] target/riscv: Remove manual decoding f


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 22/35] target/riscv: Remove manual decoding from gen_load()
Date: Wed, 31 Oct 2018 22:09:09 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 10/31/18 1:20 PM, Bastian Koppelmann wrote:
> With decodetree we don't need to convert RISC-V opcodes into to MemOps
> as the old gen_load() did.
> 
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Bastian Koppelmann <address@hidden>
> Signed-off-by: Peer Adelt <address@hidden><Paste>


Reviewed-by: Richard Henderson <address@hidden>

> +static bool gen_load(DisasContext *ctx, arg_lb *a, int memop)

Better with TCGMemOp instead of int.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]