Re: [Qemu-devel] [RFC 09/48] tcg: reset runtime helpers when flushing the code cache

[Emilio G. Cota]

On Wed, Nov 14, 2018 at 17:01:13 +0000, Alex Bennée wrote:
> 
> Emilio G. Cota <address@hidden> writes:
> 
> > In preparation for adding plugin support. One of the clean-up
> > actions when uninstalling plugins will be to flush the code
> > cache. We'll also have to clear the runtime helpers, since
> > some of those runtime helpers may belong to the plugin
> > being uninstalled.
> >
> > Signed-off-by: Emilio G. Cota <address@hidden>
> > ---
(snip)
> > +void tcg_reset_runtime_helpers(void);
> 
> I know tcg.h doesn't have and API doc blocks but perhaps we should
> start?
> 
>   /**
>    * tcg_reset_runtime_helpers:
>    *
>    * Remove all runtime registered helpers. Should only be called from a
>    * quiescent system while flushing old code.
>    */

Better late than never. Added to v2.

(snip)
> Otherwise:
> 
> Reviewed-by: Alex Bennée <address@hidden>

Thanks,

                E.