Re: [Qemu-devel] [PATCH v2 1/3] qemu-iotests: convert `pwd` and $(pwd) to $PWD

[Eric Blake]

On 10/24/18 4:40 AM, Mao Zhongyi wrote:
> POSIX requires $PWD to be reliable, and we expect all
> shells used by qemu scripts to be relatively close to
> POSIX.  Thus, it is smarter to avoid forking the pwd
> executable for something that is already available in
> the environment.
>
> So replac it with the following:

s/replac/replace/

> sed -i 's/`pwd`/$PWD/g' $(git grep -l "\`pwd\`")
> sed -i 's/$(pwd)/$PWD/g' $(git grep  -l "\$(pwd)")
>
> The remaining small parts are manually modified.

Reviewed-by: Eric Blake <address@hidden>

> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
>   configure                        | 2 +-
>   tests/check-block.sh             | 6 +++---
>   tests/qemu-iotests/001           | 2 +-

However, this is a LOT of churn, since patch 2 then removes many of 
these lines. I'd like to swap the two patches, and then am considering 
them going through the NBD tree.

> +++ b/tests/qemu-iotests/001
> @@ -24,7 +24,7 @@ address@hidden
>   seq=`basename $0`
>   echo "QA output created by $seq"
>   
> -here=`pwd`
> +here=$PWD
>   status=1      # failure is the default!
>   


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org