Re: [Qemu-devel] [PATCH] migration: savevm: consult migration blockers

[Wang, Wei W]

On Saturday, November 17, 2018 12:48 AM, Paolo Bonzini wrote:
> To: address@hidden
> Subject: [Qemu-devel] [PATCH] migration: savevm: consult migration
> blockers
> 
> There is really no difference between live migration and savevm, except that
> savevm does not require bdrv_invalidate_cache to be implemented by all
> disks.  However, it is unlikely that savevm is used with anything except qcow2
> disks, so the penalty is small and worth the improvement in catching bad
> usage of savevm.
> 
> Only one place was taking care of savevm when adding a migration blocker,
> and it can be removed.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  migration/savevm.c | 4 ++++
>  target/i386/kvm.c  | 3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c index
> ef707b8c43..1c49776a91 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2455,6 +2455,10 @@ int save_snapshot(const char *name, Error
> **errp)
>      struct tm tm;
>      AioContext *aio_context;
> 
> +    if (migration_is_blocked(errp)) {
> +        return false;

Just curious why returning false here when the returning type is "int"

Best,
Wei