[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_ro
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom() |
|
Date: |
Thu, 22 Nov 2018 17:48:20 +0100 |
Le jeu. 22 nov. 2018 14:36, Peter Maydell <address@hidden> a
écrit :
> The API of cpu_physical_memory_write_rom() is odd, because it
> takes an AddressSpace, unlike all the other cpu_physical_memory_*
> access functions. We note this oddity as a TODO in the
> docs/devel/loads-stores.rst documentation.
>
> Rename cpu_physical_memory_write_rom() to address_space_write_rom(),
> and give it an API that matches address_space_write().
> We also adjest the cpu_physical_memory_write_rom_internal()
> function which is local to exec.c similarly.
>
> thanks
> -- PMM
>
> Peter Maydell (2):
> exec.c: Rename cpu_physical_memory_write_rom_internal()
> Rename cpu_physical_memory_write_rom() to address_space_write_rom()
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>