Re: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
47e8b7b qapi: add query-display-options command
b38268d usb-host: set ifs.detached as true if kernel driver is not active
36275b8 audio/hda: fix guest triggerable assert
a20816e cirrus_vga/migration: update the bank offset before use
93d3ea2 ps2kbd: default to scan enabled after reset
0d552dd fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

=== OUTPUT BEGIN ===
Checking PATCH 1/6: fmops: fix off-by-one in AR_TABLE and DR_TABLE array size...
ERROR: code indent should never use tabs
#28: FILE: hw/audio/fmopl.h:75:
+^Iint32_t AR_TABLE[76];^I/* attack rate tables  */$

ERROR: code indent should never use tabs
#29: FILE: hw/audio/fmopl.h:76:
+^Iint32_t DR_TABLE[76];^I/* decay rate tables   */$

total: 2 errors, 0 warnings, 10 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: ps2kbd: default to scan enabled after reset...
Checking PATCH 3/6: cirrus_vga/migration: update the bank offset before use...
Checking PATCH 4/6: audio/hda: fix guest triggerable assert...
Checking PATCH 5/6: usb-host: set ifs.detached as true if kernel driver is not 
active...
Checking PATCH 6/6: qapi: add query-display-options command...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden