Re: [Qemu-devel] [PATCH 22/71] tests/libqos: sdhci driver and interface nodes

[Paolo Bonzini]

On 12/12/18 15:35, Philippe Mathieu-Daudé wrote:
>> +}
>> +
>> +static void qsdhci_register_nodes(void)
>> +{
>> +    QPCIAddress addr = {
>> +        .devfn = QPCI_DEVFN(4, 0),
>> +        .vendor_id = PCI_VENDOR_ID_REDHAT,
>> +        .device_id = PCI_DEVICE_ID_REDHAT_SDHCI,
>> +    };
>> +
>> +    QOSGraphEdgeOptions opts = {
>> +        .extra_device_opts = "addr=04.0",
> Shouldn't this be formatted from the previous QPCIAddress?
> 

Maybe, but there isn't a way to couple the two for now.  A device
address allocator is on the todo list. :)

Paolo