Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04

[Eric Blake]

On 2/4/19 10:08 PM, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

> 2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
> ERROR: spaces required around that '*' (ctx:WxV)
> #85: FILE: include/block/nbd.h:356:
> +                                 uint##bits##_t *val,                   \
>                                                  ^
> 
> total: 1 errors, 0 warnings, 386 lines checked
> 
> Patch 2/8 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

False positive. Seeing past ## pasting in a macro is not trivial to fix
in checkpatch, so I'm intentionally ignoring this one.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature