Re: [Qemu-devel] [PATCH v4] scripts: use git archive in archive-source

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4] scripts: use git archive in archive-source
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e92ad529b4 scripts: use git archive in archive-source

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#40: FILE: scripts/archive-source.sh:36:
+^Igit submodule deinit $sub_deinit$

ERROR: code indent should never use tabs
#70: FILE: scripts/archive-source.sh:55:
+^I-*)$

ERROR: code indent should never use tabs
#71: FILE: scripts/archive-source.sh:56:
+^I    sub_deinit="$sub_deinit $sm"$

ERROR: code indent should never use tabs
#72: FILE: scripts/archive-source.sh:57:
+^I    git submodule update --init "$sm"$

ERROR: code indent should never use tabs
#73: FILE: scripts/archive-source.sh:58:
+^I    test $? -ne 0 && error "failed to update submodule $sm"$

ERROR: code indent should never use tabs
#74: FILE: scripts/archive-source.sh:59:
+^I    ;;$

ERROR: code indent should never use tabs
#75: FILE: scripts/archive-source.sh:60:
+^I+*)$

ERROR: code indent should never use tabs
#76: FILE: scripts/archive-source.sh:61:
+^I    echo "WARNING: submodule $sm is out of sync"$

ERROR: code indent should never use tabs
#77: FILE: scripts/archive-source.sh:62:
+^I    ;;$

total: 9 errors, 0 warnings, 63 lines checked

Commit e92ad529b444 (scripts: use git archive in archive-source) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden