[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/22] hw/arm/boot: Clarify why arm_setup_firmware_bo
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 20/22] hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info |
Date: |
Tue, 5 Feb 2019 17:05:08 +0000 |
The code path for booting firmware doesn't set env->boot_info. At
first sight this looks odd, so add a comment saying why we don't.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-id: address@hidden
---
hw/arm/boot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 2d4f710395f..328cc6bd245 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -1182,7 +1182,8 @@ static void arm_setup_firmware_boot(ARMCPU *cpu, struct
arm_boot_info *info)
/*
* We will start from address 0 (typically a boot ROM image) in the
- * same way as hardware.
+ * same way as hardware. Leave env->boot_info NULL, so that
+ * do_cpu_reset() knows it does not need to alter the PC on reset.
*/
}
--
2.20.1
- [Qemu-devel] [PULL 03/22] target/arm: Add BT and BTYPE to tb->flags, (continued)
- [Qemu-devel] [PULL 05/22] target/arm: Cache the GP bit for a page in MemTxAttrs, Peter Maydell, 2019/02/05
- [Qemu-devel] [PULL 22/22] target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI, Peter Maydell, 2019/02/05
- [Qemu-devel] [PULL 13/22] target/arm: Clean TBI for data operations in the translator, Peter Maydell, 2019/02/05
- [Qemu-devel] [PULL 20/22] hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info,
Peter Maydell <=
- [Qemu-devel] [PULL 17/22] hw/arm/boot: Fix block comment style in arm_load_kernel(), Peter Maydell, 2019/02/05
- [Qemu-devel] [PULL 18/22] hw/arm/boot: Factor out "direct kernel boot" code into its own function, Peter Maydell, 2019/02/05
- [Qemu-devel] [PULL 08/22] target/arm: Set btype for indirect branches, Peter Maydell, 2019/02/05
- Re: [Qemu-devel] [PULL 00/22] target-arm queue, no-reply, 2019/02/05
- Re: [Qemu-devel] [PULL 00/22] target-arm queue, no-reply, 2019/02/05
- Re: [Qemu-devel] [PULL 00/22] target-arm queue, no-reply, 2019/02/05
- Re: [Qemu-devel] [PULL 00/22] target-arm queue, Peter Maydell, 2019/02/05