Re: [Qemu-devel] [PULLv2 00/32] More work towards libslirp

[Peter Maydell]

On Tue, 5 Feb 2019 at 16:59, Samuel Thibault
<address@hidden> wrote:
>
> The following changes since commit 01a9a51ffaf4699827ea6425cb2b834a356e159d:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190205-pull-request' 
> into staging (2019-02-05 14:01:29 +0000)
>
> are available in the Git repository at:
>
>   https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to cf20be34d44a953c9b52a4d5cf6f4232968e6f3c:
>
>   slirp: API is extern C (2019-02-05 18:56:17 +0200)
>
> ----------------------------------------------------------------
> More work towards libslirp

Fails to build, ppc64, x86-64, aarch32, s390x, etc:

/home/pm215/qemu/slirp/misc.c: In function ‘g_spawn_async_with_fds_slirp’:
/home/pm215/qemu/slirp/misc.c:166:5: error: unknown type name ‘QemuGSpawnFds’
     QemuGSpawnFds setup = {
     ^
/home/pm215/qemu/slirp/misc.c:167:9: error: field name not in record
or union initializer
         .child_setup = child_setup,
         ^
/home/pm215/qemu/slirp/misc.c:167:9: error: (near initialization for ‘setup’)
/home/pm215/qemu/slirp/misc.c:167:9: error: initialization makes
integer from pointer without a cast [-Werror]
/home/pm215/qemu/slirp/misc.c:167:9: error: (near initialization for
‘setup’) [-Werror]
/home/pm215/qemu/slirp/misc.c:168:9: error: field name not in record
or union initializer
         .user_data = user_data,
         ^
/home/pm215/qemu/slirp/misc.c:168:9: error: (near initialization for ‘setup’)
/home/pm215/qemu/slirp/misc.c:168:9: error: excess elements in scalar
initializer [-Werror]
/home/pm215/qemu/slirp/misc.c:168:9: error: (near initialization for
‘setup’) [-Werror]
/home/pm215/qemu/slirp/misc.c:169:9: error: field name not in record
or union initializer
         .stdin_fd = stdin_fd,
         ^
/home/pm215/qemu/slirp/misc.c:169:9: error: (near initialization for ‘setup’)
/home/pm215/qemu/slirp/misc.c:169:9: error: excess elements in scalar
initializer [-Werror]
/home/pm215/qemu/slirp/misc.c:169:9: error: (near initialization for
‘setup’) [-Werror]
/home/pm215/qemu/slirp/misc.c:170:9: error: field name not in record
or union initializer
         .stdout_fd = stdout_fd,
         ^
/home/pm215/qemu/slirp/misc.c:170:9: error: (near initialization for ‘setup’)
/home/pm215/qemu/slirp/misc.c:170:9: error: excess elements in scalar
initializer [-Werror]
/home/pm215/qemu/slirp/misc.c:170:9: error: (near initialization for
‘setup’) [-Werror]
/home/pm215/qemu/slirp/misc.c:171:9: error: field name not in record
or union initializer
         .stderr_fd = stderr_fd,
         ^
/home/pm215/qemu/slirp/misc.c:171:9: error: (near initialization for ‘setup’)
/home/pm215/qemu/slirp/misc.c:171:9: error: excess elements in scalar
initializer [-Werror]
/home/pm215/qemu/slirp/misc.c:171:9: error: (near initialization for
‘setup’) [-Werror]
cc1: all warnings being treated as errors

FreeBSD fails in a slightly different way:

slirp/misc.c:166:5: error: use of undeclared identifier 'QemuGSpawnFds'
    QemuGSpawnFds setup = {
    ^
slirp/misc.c:175:51: error: use of undeclared identifier 'setup'
                         slirp_gspawn_fds_setup, &setup,
                                                  ^
2 errors generated.

thanks
-- PMM