[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 15/25] contrib: compile vhost-user-blk tool by de
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PULL 15/25] contrib: compile vhost-user-blk tool by default |
|
Date: |
Fri, 8 Feb 2019 15:13:36 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Feb 04, 2019 at 08:48:14PM -0500, Michael S. Tsirkin wrote:
> On Mon, Feb 04, 2019 at 03:29:21PM +0000, Daniel P. Berrangé wrote:
> > On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote:
> > > Hmm I do think we want to build the contrib tools,
> > > otherwise they bitrot too quickly, witness follow-up
> > > patches that fix the compilation.
> > >
> > > And I think we need tests that actually use them.
> > >
> > > However I agree adding them to tools and installing
> > > is probably rushing things, e.g. there's no
> > > manpage even.
> >
> > Yes, if we build, but do not install, the binary that would be ok
> >
> >
> > Regards,
> > Daniel
>
> OK I reverted this for now.
Yes, I requested this patch to avoid further bitrot. Installing isn't
necessary though.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PULL 16/25] contrib/vhost-user-blk: fix the compilation issue, (continued)
- [Qemu-devel] [PULL 16/25] contrib/vhost-user-blk: fix the compilation issue, Michael S. Tsirkin, 2019/02/04
- [Qemu-devel] [PULL 14/25] i386/kvm: ignore masked irqs when update msi routes, Michael S. Tsirkin, 2019/02/04
- [Qemu-devel] [PULL 07/25] vhost: restrict Linux dependency to kernel vhost, Michael S. Tsirkin, 2019/02/04
- [Qemu-devel] [PULL 11/25] intel_iommu: fix operator in vtd_switch_address_space, Michael S. Tsirkin, 2019/02/04
- [Qemu-devel] [PULL 08/25] vhost-net: compile it on all targets that have virtio-net., Michael S. Tsirkin, 2019/02/04
- [Qemu-devel] [PULL 15/25] contrib: compile vhost-user-blk tool by default, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 13/25] pci/msi: export msi_is_masked(), Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 02/25] contrib/libvhost-user: switch to uint64_t, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 09/25] vhost-net: revamp configure logic, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 12/25] intel_iommu: reset intr_enabled when system reset, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 01/25] virtio: add checks for the size of the indirect table, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 10/25] hw: virtio-pci: drop DO_UPCAST, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 03/25] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1), Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 05/25] vhost-net: move stubs to a separate file, Michael S. Tsirkin, 2019/02/04
[Qemu-devel] [PULL 04/25] include: update Linux headers to 4.21-rc1/5.0-rc1, Michael S. Tsirkin, 2019/02/04
Re: [Qemu-devel] [PULL 00/25] pci, pc, virtio: fixes, cleanups, features, Peter Maydell, 2019/02/04