Re: [Qemu-devel] [PATCH v3 06/13] Add vhost-user-backend

[Marc-André Lureau]

Hi
On Mon, Feb 11, 2019 at 12:01 PM Daniel P. Berrangé <address@hidden> wrote:
>
> On Fri, Feb 08, 2019 at 12:23:50PM +0100, Marc-André Lureau wrote:
> > Create a vhost-user-backend object that holds a connection to a
> > vhost-user backend and can be referenced from virtio devices that
> > support it. See later patches for input & gpu usage.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  include/sysemu/vhost-user-backend.h |  60 ++++++++
> >  backends/vhost-user.c               | 213 ++++++++++++++++++++++++++++
> >  MAINTAINERS                         |   2 +
> >  backends/Makefile.objs              |   3 +-
> >  4 files changed, 277 insertions(+), 1 deletion(-)
> >  create mode 100644 include/sysemu/vhost-user-backend.h
> >  create mode 100644 backends/vhost-user.c
> >
> > diff --git a/include/sysemu/vhost-user-backend.h 
> > b/include/sysemu/vhost-user-backend.h
> > new file mode 100644
> > index 0000000000..60f811cae7
> > --- /dev/null
> > +++ b/include/sysemu/vhost-user-backend.h
> > @@ -0,0 +1,60 @@
> > +/*
> > + * QEMU vhost-user backend
> > + *
> > + * Copyright (C) 2018 Red Hat Inc
> > + *
> > + * Authors:
> > + *  Marc-André Lureau <address@hidden>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or 
> > later.
> > + * See the COPYING file in the top-level directory.
> > + */
> > +#ifndef QEMU_VHOST_USER_BACKEND_H
> > +#define QEMU_VHOST_USER_BACKEND_H
> > +
> > +#include "qom/object.h"
> > +#include "exec/memory.h"
> > +#include "qemu/option.h"
> > +#include "qemu/bitmap.h"
> > +#include "hw/virtio/vhost.h"
> > +#include "hw/virtio/vhost-user.h"
> > +#include "chardev/char-fe.h"
> > +#include "io/channel.h"
> > +
> > +#define TYPE_VHOST_USER_BACKEND "vhost-user-backend"
> > +#define VHOST_USER_BACKEND(obj) \
> > +    OBJECT_CHECK(VhostUserBackend, (obj), TYPE_VHOST_USER_BACKEND)
> > +#define VHOST_USER_BACKEND_GET_CLASS(obj) \
> > +    OBJECT_GET_CLASS(VhostUserBackendClass, (obj), TYPE_VHOST_USER_BACKEND)
> > +#define VHOST_USER_BACKEND_CLASS(klass) \
> > +    OBJECT_CLASS_CHECK(VhostUserBackendClass, (klass), 
> > TYPE_VHOST_USER_BACKEND)
> > +
> > +typedef struct VhostUserBackend VhostUserBackend;
> > +typedef struct VhostUserBackendClass VhostUserBackendClass;
> > +
> > +struct VhostUserBackendClass {
> > +    ObjectClass parent_class;
> > +};
> > +
> > +struct VhostUserBackend {
> > +    /* private */
> > +    Object parent;
> > +
> > +    char *cmd;
>
> This field doesn't appear to be used any more

Good catch! thanks

>
> > +    char *chr_name;
> > +
> > +    CharBackend chr;
> > +    VhostUserState vhost_user;
> > +    struct vhost_dev dev;
> > +    QIOChannel *child;
> > +    VirtIODevice *vdev;
> > +    bool started;
> > +    bool completed;
> > +};
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|