[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] target/hppa: fix '</<=' conditions
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] target/hppa: fix '</<=' conditions |
Date: |
Mon, 11 Feb 2019 20:26:37 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/11/19 10:19 AM, Sven Schnelle wrote:
> case 3: /* <= / > (N | Z / !N & !Z) */
> - cond = cond_make_0(TCG_COND_LE, res);
> + tmp = tcg_temp_new();
> + tcg_gen_xor_reg(tmp, res, sv);
> + cond = cond_make_0(TCG_COND_LE, tmp);
> + tcg_temp_free(tmp);
> break;
So the test here should be (N ^ V) | Z, which is not what you're testing. I've
fixed this up locally.
r~
- [Qemu-devel] [PATCH 1/5] target/hppa: move GETPC to HELPER() functions, Sven Schnelle, 2019/02/11
- [Qemu-devel] [PATCH 5/5] target/hppa: fix dcor instruction, Sven Schnelle, 2019/02/11
- [Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions, Sven Schnelle, 2019/02/11
- [Qemu-devel] [PATCH 3/5] target/hppa: fix log conditions, Sven Schnelle, 2019/02/11
- [Qemu-devel] [PATCH 2/5] target/hppa: fix '</<=' conditions, Sven Schnelle, 2019/02/11
- Re: [Qemu-devel] [PATCH 2/5] target/hppa: fix '</<=' conditions,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH 1/5] target/hppa: move GETPC to HELPER() functions, Richard Henderson, 2019/02/11