Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

[Alex Bennée]

Thomas Huth <address@hidden> writes:

> On 2019-02-13 13:06, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Feb 13, 2019 at 12:55 PM Thomas Huth <address@hidden> wrote:
>>>
>>> This is very convenient for people like me who store their QEMU git trees
>>> on gitlab.com: Automatic CI pipelines are now run for each branch that is
>>> pushed to the server - useful for some extra-testing before sending PULL-
>>> requests for example. Since the runtime of the jobs is limited to 1h, the
>>> jobs are distributed into multiple pipelines - this way everything finishs
>>> fine within time (ca. 30 minutes currently).
>>>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>>  An example can be seen here: https://gitlab.com/huth/qemu/pipelines/
>>>
>>>  I'd really like to get this into the main QEMU repository, so that I don't
>>>  have to cherry-pick this patch onto my testing branches anymore each time
>>>  I want to test before sending a PULL request...
>>>
>>>  .gitlab-ci.yml | 73 
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  MAINTAINERS    |  5 ++++
>>>  2 files changed, 78 insertions(+)
>>>  create mode 100644 .gitlab-ci.yml
>>>
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> new file mode 100644
>>> index 0000000..79d02cf
>>> --- /dev/null
>>> +++ b/.gitlab-ci.yml
>>> @@ -0,0 +1,73 @@
>>> +before_script:
>>> + - apt-get update -qq
>>> + - apt-get install -y -qq flex bison libglib2.0-dev libpixman-1-dev 
>>> genisoimage
>>> +
>>> +build-system1:
>>> + script:
>>> + - apt-get install -y -qq libgtk-3-dev libvte-dev nettle-dev libcacard-dev
>>> +      libusb-dev libvde-dev libspice-protocol-dev libgl1-mesa-dev
>>> + - ./configure --enable-werror --target-list="aarch64-softmmu alpha-softmmu
>>> +      cris-softmmu hppa-softmmu lm32-softmmu moxie-softmmu 
>>> microblazeel-softmmu
>>> +      mips64el-softmmu m68k-softmmu ppc-softmmu riscv64-softmmu 
>>> sparc-softmmu"
>>> + - make -j2
>>
>> Have you tried $(nproc) ?
>
> The containers are only single CPU there. I'm using -j2 just in case one
> of the processes is blocked by waiting for IO, the other one can still
> continue compiling.
>
>> Despite the duplication of CI files, which is not really a problem imho,
>>
>> lgtm,
>> Reviewed-by: Marc-André Lureau <address@hidden>
>
> Thanks!
>
> And yes, I also think the duplication of the CI files should not really
> be a problem - it's rather a plus since we also got test variations this
> way. I already found some bugs with this here that were not detected by
> the other CI setups yet (e.g. since one of the pipelines uses
> --disable-replication and other --disable-xxx flags).

Sure I'm happy to have a thousand flowers bloom in this regard.

Do you know if gitlab does build status buttons like the others?

--
Alex Bennée