[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] hostmem-file: reject invalid pmem file s
From: |
Pankaj Gupta |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] hostmem-file: reject invalid pmem file sizes |
Date: |
Thu, 14 Feb 2019 03:50:18 -0500 (EST) |
>
> v3:
> * Added Patch 1 by Igor [Wei]
> * Moved pmem size check after mem_path check [Wei]
>
> Guests started with NVDIMMs larger than the underlying host file produce
> confusing errors inside the guest. This happens because the guest
> accesses pages beyond the end of the file.
>
> Check the pmem file size on startup and print a clear error message if
> the size is invalid.
>
> Igor Mammedov (1):
> hostmem: simplify ifdef-s in file_backend_memory_alloc()
>
> Stefan Hajnoczi (1):
> hostmem-file: reject invalid pmem file sizes
>
> include/qemu/osdep.h | 13 ++++++++++
> backends/hostmem-file.c | 32 +++++++++++++++++++++----
> util/oslib-posix.c | 53 +++++++++++++++++++++++++++++++++++++++++
> util/oslib-win32.c | 5 ++++
> 4 files changed, 98 insertions(+), 5 deletions(-)
>
> --
> 2.20.1
Both the patches look good to me.
Reviewed-by: Pankaj Gupta <address@hidden>