Re: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b6de88ab3a ui/cocoa: Perform UI operations only on the main thread
1940bfd263 ui/cocoa: Subclass NSApplication so we can implement sendEvent
724525dbfc ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
dcd07aa31c ui/cocoa: Move console/device menu creation code up in file
f0890fa38d ui/cocoa: Factor out initial menu creation
9669817763 ui/cocoa: Use the pixman image directly in switchSurface
bcffb41705 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit bcffb41705d0 (ui/cocoa: Ensure we have the iothread lock 
when calling into QEMU)
2/7 Checking commit 96698177637f (ui/cocoa: Use the pixman image directly in 
switchSurface)
3/7 Checking commit f0890fa38dc1 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit dcd07aa31c3b (ui/cocoa: Move console/device menu creation 
code up in file)
5/7 Checking commit 724525dbfc09 (ui/cocoa: Don't call NSApp sendEvent directly 
from handleEvent)
ERROR: trailing whitespace
#41: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 1940bfd26326 (ui/cocoa: Subclass NSApplication so we can 
implement sendEvent)
7/7 Checking commit b6de88ab3a67 (ui/cocoa: Perform UI operations only on the 
main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden