Re: [Qemu-devel] [PATCH] mips: implement qmp query-cpu-definitions command

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> Hi Pavel,
>
> On 2/11/19 6:34 AM, Pavel Dovgalyuk wrote:
>> Ping.
>
> You forgot to Cc Aleksandar, to get his MIPS maintainer Ack-by:
>
> ./scripts/get_maintainer.pl -f target/mips/helper.c
> Aleksandar Markovic <address@hidden> (maintainer:MIPS)
>
>> 
>> Pavel Dovgalyuk
>> 
>>> -----Original Message-----
>>> From: Pavel Dovgalyuk [mailto:address@hidden
>>> Sent: Tuesday, February 05, 2019 4:08 PM
>>> To: address@hidden
>>> Cc: address@hidden; address@hidden; address@hidden;
>>> address@hidden; address@hidden; address@hidden; address@hidden;
>>> address@hidden
>>> Subject: [PATCH] mips: implement qmp query-cpu-definitions command
>>>
>>> This patch enables QMP-based querying of the available CPU types for MIPS
>>> and MIPS64 platforms.
>
> Your patch is a simple copy of the ARM code, so:
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Also:
>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> However this clashes with Marc-André's "qapi: make query-cpu-definitions
> depend on specific targets" posted here by Markus:
> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg03831.html

This is now in master, merge commit a0430dd8abb.

> I believe your patch will go thru the QMP tree, so you might want to
> rebase on top of the series Markus sent; or see if Markus is OK to do
> the manual cleanup when applying.

Please rebase.  Let me know if you need help.