Re: [Qemu-devel] [PATCH v4 4/8] target/arm: Implement ARMv8.3-JSConv

[Peter Maydell]

On Fri, 15 Feb 2019 at 19:23, Richard Henderson
<address@hidden> wrote:
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> v2: Return 0 for NaN
> v3: Return aa32 flags in FPSCR.NZCV.


> +            /* The number is so large we must shift the fraction left.  */
> +            if (shift >= 64) {
> +                /* The the fraction is shifted out entirely.  */

Stil "The the".

> +                frac = 0;
> +            } else {
> +                frac <<= shift;
> +            }

> +uint32_t HELPER(vjcvt)(float64 value, CPUARMState *env)
> +{
> +    uint64_t pair = HELPER(fjcvtzs)(value, &env->vfp.fp_status);
> +    uint32_t result = pair;
> +    uint32_t z = (pair >> 32) == 0;
> +
> +    /* Store Z, clear NCV, in FPSCR.NZCF.  */

"NZCV".

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

If these are the only issues in the series I'll fix them as
I apply it.

thanks
-- PMM