qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup


From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup
Date: Thu, 21 Feb 2019 14:03:19 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1



On 2/20/19 8:51 AM, Wei Yang wrote:
Three trivial cleanup for pc-dimm.

Patch [1] remove the check on class->hotpluggable since pc-dimm is always
hotpluggable.
Patch [2] remove nvdimm_realize
Patch [2] remove pcdimm realize-callback

v2:
   * fix warning in Patch 1
   * split Patch 2 into two

Wei Yang (3):
   pc-dimm: remove check on pc-dimm hotpluggable
   mem/nvdimm: remove nvdimm_realize

   pc-dimm: revert "introduce realize callback"

I think the word 'revert' is not so precise as that hints
the commit is bugly, instead, it was factored in the later
comments then becomes useless now.

Anyway, this pathset looks good to me.

Reviewed-by: Xiao Guangrong <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]