[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] vfio/display: add xres + yres properties
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] vfio/display: add xres + yres properties |
Date: |
Thu, 21 Feb 2019 10:35:36 -0700 |
On Thu, 21 Feb 2019 08:46:43 +0100
Gerd Hoffmann <address@hidden> wrote:
> Hi,
>
> > > + DEFINE_PROP_UINT32("xres", VFIOPCIDevice, display_xres, 0),
> > > + DEFINE_PROP_UINT32("yres", VFIOPCIDevice, display_yres, 0),
> >
> > This is actually quite fun, I started my VM with arbitrary numbers and
> > the Windows GUI honored it every time. Probably very useful for
> > playing with odd screen sizes. I also tried to break it using
> > 1000000x1000000, but the display came up as 1920x1200, the maximum
> > resolution GVT-g supports for this type. I don't see that QEMU is
> > bounding this though, do we depend on the mdev device to ignore it if
> > we pass values it cannot support?
>
> There is a check in vfio_display_edid_update().
Ok, so we're bounded within QEMU, that seems good. Thanks,
Alex