qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launch


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client
Date: Fri, 22 Feb 2019 06:51:35 +0100
User-agent: NeoMutt/20180716

  Hi,

> Would something like that be helpful?
> 
> diff --git a/ui/spice-app.c b/ui/spice-app.c
> index 4f5229f3ee..69f92e440c 100644
> --- a/ui/spice-app.c
> +++ b/ui/spice-app.c
> @@ -181,6 +181,7 @@ static void spice_app_display_init(DisplayState
> *ds, DisplayOptions *opts)
>      g_app_info_launch_default_for_uri(uri, NULL, &err);
>      if (err) {
>          error_report("Failed to launch %s URI: %s", uri, err->message);
> +        error_report("You need a capable Spice client, such as
> virt-viewer 8.0");

Yep, looks good to me.  Can you send that as incremental patch?

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]