Re: [Qemu-devel] [PATCH v3 0/7] ui/cocoa: Use OSX's main loop

[Peter Maydell]

...oops, looks like I got Roman's email address wrong (I
cut-n-pasted it from the one reviewed-by tag that happened
to typo it :-( ). Sorry about that.

-- PMM

On Mon, 25 Feb 2019 at 10:24, Peter Maydell <address@hidden> wrote:
>
> This set of patches rearranges how we handle events on
> the OSX Cocoa UI so that we use the main thread to run
> the OSX event loop, and we don't do a long blocking
> operation from the applicationDidFinishLaunching callback.
> Instead we create a second thread which runs qemu_main()
> and becomes the QEMU main-loop thread. The callbacks from
> QEMU into the cocoa code asynchronously dispatch their
> work to the main thread, and the main thread takes the
> iothread lock before calling into QEMU code.
>
> The changes from v2 to v3 are all minor, and all patches
> have now had review/test; I plan to apply this to master
> towards the end of the week, absent any further review
> comments.
>
>  * patch 1: add with_iothread_lock wrap to qmp_stop/qmp_cont calls
>  * patch 5: remove stray whitespace
>  * patch 7: remove unnecessary null check on cocoaView
>  * patch 7: make semaphore variables file-local
>  * patch 7: deref pixman_image in dealloc
>
> thanks
> -- PMM