Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

[Markus Armbruster]

Stefan Hajnoczi <address@hidden> writes:

> On Mon, Feb 25, 2019 at 09:50:26AM +0100, Markus Armbruster wrote:
>> Stefan Hajnoczi <address@hidden> writes:
>> 
>> > QMP clients can usually detect the presence of features via schema
>> > introspection.  There are rare features that do not involve schema
>> > changes and are therefore impossible to detect with schema
>> > introspection.
>> >
>> > This patch adds the query-qemu-capabilities command.  It returns a list
>> > of capabilities that this QEMU supports.
>> 
>> The name "capabilities" could be confusing, because we already have QMP
>> capabilities, complete with command qmp_capabilities.  Would "features"
>> work?
>
> Sure, will fix.
>
>> > The decision to make this a command rather than something statically
>> > defined in the schema is intentional.  It allows QEMU to decide which
>> > capabilities are available at runtime, if necessary.
>> >
>> > This new interface is necessary so that QMP clients can discover that
>> > migrating disk image files is safe with cache.direct=off on Linux.
>> > There is no other way to detect whether or not QEMU supports this.
>> 
>> I think what's unsaid here is that we don't want to make a completely
>> arbitrary schema change just to carry this bit of information.  We
>> could, but we don't want to.  Correct?
>
> Yes, exactly.

Then let's rephrase a little:

     QMP clients can usually detect the presence of features via schema
     introspection.  There are rare features that do not involve schema
     changes.  To make them detectable with schema introspection, we'd
     have to make some arbitrary schema change.  Annoying.

     The new query-qemu-features command lets us avoid that.  It returns
     a list of features supported by this QEMU.

     The decision to make this a command rather than something statically
     defined in the schema is intentional.  It allows QEMU to decide which
     capabilities are available at runtime, if necessary.

     Use the new command to declare migrating disk image files is safe
     with cache.direct=off on Linux.

[...]