Re: [Qemu-devel] [PULL 00/13] Netpatches

[Dr. David Alan Gilbert]

* Peter Maydell (address@hidden) wrote:
> On Fri, 22 Feb 2019 at 14:55, Jason Wang <address@hidden> wrote:
> >
> > The following changes since commit 7817ea16c1bb91ba3849e704d5f3e3c5775087bf:
> >
> >   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190221' into 
> > staging (2019-02-22 13:04:42 +0000)
> >
> > are available in the git repository at:
> >
> >   https://github.com/jasowang/qemu.git tags/net-pull-request
> >
> > for you to fetch changes up to eb4702b3ffcf11ec62f0c401f77f49219594e95c:
> >
> >   net: netmap: improve netmap_receive_iov() (2019-02-22 22:39:24 +0800)
> >
> > ----------------------------------------------------------------
> >
> > ----------------------------------------------------------------
> 
> Fails to build on at least some hosts:
> 
> cc -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g   -Wl,--warn-common -g
>   /home/pm215/qemu/tests/test-announce-self.c tests/libqtest.o
> libqemuutil.a   -o tests/test-announce-self
> /home/pm215/qemu/tests/test-announce-self.c:11:24: fatal error:
> qemu/osdep.h: No such file or directory
>  #include "qemu/osdep.h"
>                         ^
> 
> 
> Something looks to be wrong with the command line here -- it is
> not adding the usual/expected set of QEMU cflags (and in particular
> is missing the option that adds the QEMU source tree to the
> include path).

OK, I see it, I was missing a :
+tests/test-announce-self$(EXESUF): tests/test-announce-self.o

line

Curious that it worked on some platforms; I guess maybe there's an
implicit rule somewhere.

Dave

> thanks
> -- PMM
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK