[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a sem
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore |
|
Date: |
Wed, 27 Feb 2019 13:26:21 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 22, 2019 at 11:14:10AM +0800, Peter Xu wrote:
> Only sending an init-done message using lock+cond seems an overkill to
> me. Replacing it with a simpler semaphore.
>
> Meanwhile, init the semaphore unconditionally, then we can destroy it
> unconditionally too in finalize which seems cleaner.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> include/sysemu/iothread.h | 3 +--
> iothread.c | 17 ++++-------------
> 2 files changed, 5 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
[Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally, Peter Xu, 2019/02/21
[Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally, Peter Xu, 2019/02/21
[Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn, Peter Xu, 2019/02/21