[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Nested SVM only enabled (by default) in pc-i440fx-2.1?
From: |
Mark Kanda |
Subject: |
[Qemu-devel] Nested SVM only enabled (by default) in pc-i440fx-2.1? |
Date: |
Wed, 27 Feb 2019 16:05:23 -0600 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 |
Hi all,
I noticed nested SVM is enabled only in pc-i440fx-2.1 (default is
disabled); this was added when 2.1 was the latest:
75d373ef97 ("target-i386: Disable SVM by default in KVM mode")
However, this change was not carried forward to newer machine types. Is
this an oversight? Is there a reason we (still) need SVM disabled by
default?
Default setting - target/i386/cpu.c:
static PropValue kvm_default_props[] = {
{ "kvmclock", "on" },
...
{ "monitor", "off" },
{ "svm", "off" },
{ NULL, NULL },
};
2.1 override - hw/i386/pc_piix.c:
static void pc_compat_2_1_fn(MachineState *machine)
{
pc_compat_2_2_fn(machine);
x86_cpu_change_kvm_default("svm", NULL);
}
Thanks and best regards,
-Mark
- [Qemu-devel] Nested SVM only enabled (by default) in pc-i440fx-2.1?,
Mark Kanda <=