[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK * |
Date: |
Wed, 27 Feb 2019 16:03:53 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/26/19 3:39 AM, David Hildenbrand wrote:
> Combine all variant in a single handler. As source and destination
> have different element sizes, we can't use gvec expansion. Expand
> manually. Also watch out for overlapping source and destination and
> use a temporary register in that case.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/insn-data.def | 8 +++++++
> target/s390x/translate_vx.inc.c | 41 +++++++++++++++++++++++++++++++++
> 2 files changed, 49 insertions(+)
This works as is, so
Reviewed-by: Richard Henderson <address@hidden>
But the same comment applies wrt iteration order and not needing a temporary.
High unpack can iterate backward, while low unpack can iterate forward, with no
lost data.
r~
- Re: [Qemu-devel] [PATCH v1 32/33] s390x/tcg: Implement VECTOR STORE WITH LENGTH, (continued)
[Qemu-devel] [PATCH v1 30/33] s390x/tcg: Implement VECTOR STORE ELEMENT, David Hildenbrand, 2019/02/26
[Qemu-devel] [PATCH v1 25/33] s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE, David Hildenbrand, 2019/02/26
[Qemu-devel] [PATCH v1 26/33] s390x/tcg: Implement VECTOR SCATTER ELEMENT, David Hildenbrand, 2019/02/26