[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/11] Makefile, configure: Support building
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/11] Makefile, configure: Support building rST documentation |
Date: |
Thu, 28 Feb 2019 16:25:39 +0000 |
On Thu, 28 Feb 2019 at 15:49, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Hi Peter,
>
> On 2/28/19 3:56 PM, Peter Maydell wrote:
> > if test "$docs" != "no" ; then
> > - if has makeinfo && has pod2man; then
> > + if has makeinfo && has pod2man && has sphinx-build; then
>
> Unrelated to your patch, I tried that on fresh Fedora image where no
> python2 installed (on purpose). sphinx-build is not included in the
> suggested python3-sphinx. Once python2-sphinx installed (which pull a
> lot of py2 packages) I could test your series.
Yeah, Fedora gives the Python 3 version of the tool a silly name.
I'm told newer Fedora fix this.
> Again, not related to your patch, but 'make install-sphinxdocs' clone
> libfdt + capstone, requires C compiler to build libfdt.a and C++ to
> build libcapstone.a. Once both build we can generate the doc.
Yes, this sounds like an unrelated thing -- our makefiles
sometimes does more work than you expect because of some
things that we do up front (like building anything in
GENERATED_FILES, or doing this subdirs stuff). You can see
that sometimes when you do 'make clean' and it builds a
bunch of stuff before deleting it.
> > +# Sphinx builds all its documentation at once in one invocation
> > +# and handles "don't rebuild things unless necessary" itself.
> > +# The '.doctrees' files are cached information to speed this up.
>
> Can you add .doctrees to .gitignore?
Sure. I tend to forget about this because I never do in-tree
builds, so anything in the build directory doesn't show up
in git status separately.
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
Thanks for the review.
-- PMM
- [Qemu-devel] [PATCH v2 05/11] docs/conf.py: Configure the 'alabaster' theme, (continued)
- [Qemu-devel] [PATCH v2 05/11] docs/conf.py: Configure the 'alabaster' theme, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 04/11] docs/conf.py: Disable unused _static directory, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 06/11] docs/conf.py: Don't include rST sources in HTML build, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 08/11] docs: Provide separate conf.py for each manual we want, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 07/11] docs/conf.py: Disable option warnings, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 10/11] Makefile: Abstract out "identify the pkgversion" code, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 11/11] docs/conf.py: Don't hard-code QEMU version, Peter Maydell, 2019/02/28
- [Qemu-devel] [PATCH v2 09/11] Makefile, configure: Support building rST documentation, Peter Maydell, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, no-reply, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, no-reply, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, Aleksandar Markovic, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, no-reply, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, no-reply, 2019/02/28
- Re: [Qemu-devel] [PATCH v2 00/11] Enable build and install of our rST docs, no-reply, 2019/02/28