[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cas
From: |
minyard |
Subject: |
[Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c |
Date: |
Thu, 28 Feb 2019 12:17:06 -0600 |
From: Corey Minyard <address@hidden>
Create a type name and a cast macro and use those through the
code.
Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i2c/smbus_eeprom.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 2816e35bcc..76f0d4aab0 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -32,6 +32,11 @@
//#define DEBUG
+#define TYPE_SMBUS_EEPROM "smbus-eeprom"
+
+#define SMBUS_EEPROM(obj) \
+ OBJECT_CHECK(SMBusEEPROMDevice, (obj), TYPE_SMBUS_EEPROM)
+
typedef struct SMBusEEPROMDevice {
SMBusDevice smbusdev;
void *data;
@@ -40,7 +45,7 @@ typedef struct SMBusEEPROMDevice {
static uint8_t eeprom_receive_byte(SMBusDevice *dev)
{
- SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev;
+ SMBusEEPROMDevice *eeprom = SMBUS_EEPROM(dev);
uint8_t *data = eeprom->data;
uint8_t val = data[eeprom->offset++];
@@ -53,7 +58,7 @@ static uint8_t eeprom_receive_byte(SMBusDevice *dev)
static int eeprom_write_data(SMBusDevice *dev, uint8_t *buf, uint8_t len)
{
- SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev;
+ SMBusEEPROMDevice *eeprom = SMBUS_EEPROM(dev);
uint8_t *data = eeprom->data;
#ifdef DEBUG
@@ -75,7 +80,7 @@ static int eeprom_write_data(SMBusDevice *dev, uint8_t *buf,
uint8_t len)
static void smbus_eeprom_realize(DeviceState *dev, Error **errp)
{
- SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *)dev;
+ SMBusEEPROMDevice *eeprom = SMBUS_EEPROM(dev);
eeprom->offset = 0;
}
@@ -99,7 +104,7 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass,
void *data)
}
static const TypeInfo smbus_eeprom_info = {
- .name = "smbus-eeprom",
+ .name = TYPE_SMBUS_EEPROM,
.parent = TYPE_SMBUS_DEVICE,
.instance_size = sizeof(SMBusEEPROMDevice),
.class_init = smbus_eeprom_class_initfn,
@@ -116,7 +121,7 @@ void smbus_eeprom_init_one(I2CBus *smbus, uint8_t address,
uint8_t *eeprom_buf)
{
DeviceState *dev;
- dev = qdev_create((BusState *) smbus, "smbus-eeprom");
+ dev = qdev_create((BusState *) smbus, TYPE_SMBUS_EEPROM);
qdev_prop_set_uint8(dev, "address", address);
qdev_prop_set_ptr(dev, "data", eeprom_buf);
qdev_init_nofail(dev);
--
2.17.1
- [Qemu-devel] [PULL 00/19] Fix/add vmstate handling in some I2C code, minyard, 2019/02/28
- [Qemu-devel] [PULL 02/19] i2c: have I2C receive operation return uint8_t, minyard, 2019/02/28
- [Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 06/19] i2c:smbus: Simplify write operation, minyard, 2019/02/28
- [Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c,
minyard <=
- [Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 01/19] i2c: Split smbus into parts, minyard, 2019/02/28
- [Qemu-devel] [PULL 17/19] i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 04/19] i2c: Don't check return value from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 11/19] i2c:pm_smbus: Fix pm_smbus handling of I2C block read, minyard, 2019/02/28
- [Qemu-devel] [PULL 10/19] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2019/02/28
- [Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statements consistent, minyard, 2019/02/28
- [Qemu-devel] [PULL 16/19] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size, minyard, 2019/02/28
- [Qemu-devel] [PULL 05/19] i2c:smbus: Correct the working of quick commands, minyard, 2019/02/28
- [Qemu-devel] [PULL 07/19] i2c:smbus: Simplify read handling, minyard, 2019/02/28