Re: [Qemu-devel] [PATCH] Use wide-character ncurses functions.

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] Use wide-character ncurses functions.
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
5379fb5216 Use wide-character ncurses functions.

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#47: FILE: ui/curses.c:53:
+    // 0x0_

ERROR: do not use C99 // comments
#53: FILE: ui/curses.c:59:
+    // 0x1_

ERROR: do not use C99 // comments
#59: FILE: ui/curses.c:65:
+    // 0x2_

ERROR: do not use C99 // comments
#63: FILE: ui/curses.c:69:
+    // 0x3_

ERROR: do not use C99 // comments
#67: FILE: ui/curses.c:73:
+    // 0x4_

ERROR: do not use C99 // comments
#71: FILE: ui/curses.c:77:
+    // 0x5_

ERROR: do not use C99 // comments
#75: FILE: ui/curses.c:81:
+    // 0x6_

ERROR: do not use C99 // comments
#79: FILE: ui/curses.c:85:
+    // 0x7_

ERROR: do not use C99 // comments
#83: FILE: ui/curses.c:89:
+    // 0x8_

ERROR: do not use C99 // comments
#89: FILE: ui/curses.c:95:
+    // 0x9_

ERROR: do not use C99 // comments
#95: FILE: ui/curses.c:101:
+    // 0xA_

ERROR: do not use C99 // comments
#101: FILE: ui/curses.c:107:
+    // 0xB_

ERROR: do not use C99 // comments
#107: FILE: ui/curses.c:113:
+    // 0xC_

ERROR: do not use C99 // comments
#113: FILE: ui/curses.c:119:
+    // 0xD_

ERROR: do not use C99 // comments
#119: FILE: ui/curses.c:125:
+    // 0xE_

ERROR: do not use C99 // comments
#125: FILE: ui/curses.c:131:
+    // 0xF_

total: 16 errors, 0 warnings, 177 lines checked

Commit 5379fb5216b5 (Use wide-character ncurses functions.) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden