Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for boston board

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for boston 
board
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ec8fb94aea Adds virtio_net as the default netcard for boston board

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#35: FILE: hw/mips/boston.c:429:
+^IPCIDevice *eth;$

ERROR: code indent should never use tabs
#37: FILE: hw/mips/boston.c:431:
+^I/*Please set CONFIG_VIRTIO && CONFIG_VIRTIO_PCI && CONFIG_VIRTIO_NET$

WARNING: Block comments use a leading /* on a separate line
#37: FILE: hw/mips/boston.c:431:
+       /*Please set CONFIG_VIRTIO && CONFIG_VIRTIO_PCI && CONFIG_VIRTIO_NET

ERROR: code indent should never use tabs
#38: FILE: hw/mips/boston.c:432:
+^Iof Linux kernel.*/$

WARNING: Block comments use * on subsequent lines
#38: FILE: hw/mips/boston.c:432:
+       /*Please set CONFIG_VIRTIO && CONFIG_VIRTIO_PCI && CONFIG_VIRTIO_NET
+       of Linux kernel.*/

WARNING: Block comments use a trailing */ on a separate line
#38: FILE: hw/mips/boston.c:432:
+       of Linux kernel.*/

ERROR: code indent should never use tabs
#39: FILE: hw/mips/boston.c:433:
+^Ieth = pci_create(bus,$

ERROR: code indent should never use tabs
#40: FILE: hw/mips/boston.c:434:
+^I^I^I^I^I PCI_DEVFN(0, 1), "virtio-net-pci");$

ERROR: code indent should never use tabs
#42: FILE: hw/mips/boston.c:436:
+^Iqdev_set_nic_properties(&eth->qdev, &nd_table[0]);$

ERROR: code indent should never use tabs
#43: FILE: hw/mips/boston.c:437:
+^Iqdev_init_nofail(&eth->qdev);$

ERROR: code indent should never use tabs
#54: FILE: hw/mips/boston.c:564:
+^I/* Network card */$

ERROR: code indent should never use tabs
#55: FILE: hw/mips/boston.c:565:
+^Inetwork_init(&PCI_BRIDGE(&pcie2->root)->sec_bus);$

total: 9 errors, 3 warnings, 36 lines checked

Commit ec8fb94aeabb (Adds virtio_net as the default netcard for boston board) 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden