[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] Header cleanups for functions declared i
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] Header cleanups for functions declared in utils/ files |
|
Date: |
Mon, 1 Apr 2019 07:55:32 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 |
On 4/1/19 4:26 AM, Aruna Jayasena wrote:
> Declarations were moved out of qemu-common.h for functions declared in utils/
> files.
> This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
>
> Signed-off-by: Aruna Jayasena <address@hidden>
>
> ---
Thanks for working on this! Some hints for better reviews:
- you sent a series, but did not include a 0/2 cover letter; our
automated CI tools do best when there is a cover letter
- you did not describe how v2 differs from v1; here after the --- is a
good spot to mention it, to help reviewers double-check your changes from v1
More patch submission hints can be found at
https://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature