Re: [Qemu-devel] [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions

[Aleksandar Markovic]

> From: Mateja Marjanovic <address@hidden>
> Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions
>

The title look incomplete and uninformative: it mentions "the division by zero"
- but what is done in this case? Is this an implementation of that case? Or fix?
Or something else?

The title should clearly and in a condensed form explain what is done in the
series.

> From: Mateja Marjanovic <address@hidden>
>
> Integer division by zero in MSA insturctions results in unpredictable
> behaviour, but according to the hardware, it depends on the sign of
> the dividend, or always returns the same value.
> 

This is a very unclear sentence.

A sentence that says that the series makes the behavior of QEMU
and the reference hardware the same in cases of division and modulus
operations with zero divisor is missing.

> Mateja Marjanovic (2):
>  target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed
>  target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed
>
> target/mips/msa_helper.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)

Check spelling.

Thanks,
Aleksandar